Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: SQL 2016 #129

Merged
merged 3 commits into from
Feb 6, 2024
Merged

todo: SQL 2016 #129

merged 3 commits into from
Feb 6, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Feb 6, 2024

What problem does this PR solve?

Added use case test for SQL 2016 (from SpacetimeDB)

What is changed and how it works?

  • Column defaults to nullable
  • Fix the problem that Column is not lowercase when creating Table
  • Added support for TypedString
  • Support START TRANSACTION & COMMIT WORK on Server
  • Fixed floating point number display problem and prioritized converting floating point numbers to double for calculation.
  • support only select case, e.g. select 'hello'
  • support StringConcat, e.g. select 'foo' || 'bar'
  • support QualifiedWildcard, e.g. select t1.* from t1
  • support Decimal Alias Dec

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

- Column defaults to nullable
- Fix the problem that Column is not lowercase when creating Table
- Added support for `TypedString`
- Support `START TRANSACTION & COMMIT WORK` on Server
- Fixed floating point number display problem and prioritized converting floating point numbers to double for calculation.
@KKould KKould merged commit c6d0536 into KipData:main Feb 6, 2024
2 of 3 checks passed
@KKould KKould added documentation Improvements or additions to documentation bug Something isn't working enhancement New feature or request invalid This doesn't seem right labels Feb 6, 2024
@KKould KKould self-assigned this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant