-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented index-based array assignments #677
Merged
Luna-Klatzer
merged 8 commits into
dev-next
from
669-feature-implement-assignment-to-arrays-based-on-index
Jul 24, 2024
Merged
Implemented index-based array assignments #677
Luna-Klatzer
merged 8 commits into
dev-next
from
669-feature-implement-assignment-to-arrays-based-on-index
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-next #677 +/- ##
============================================
+ Coverage 83.98% 84.00% +0.02%
============================================
Files 270 270
Lines 4502 4514 +12
Branches 479 481 +2
============================================
+ Hits 3781 3792 +11
- Misses 582 583 +1
Partials 139 139 ☔ View full report in Codecov by Sentry. |
…ternals for actual function type checking with references
Luna-Klatzer
force-pushed
the
669-feature-implement-assignment-to-arrays-based-on-index
branch
from
July 24, 2024 09:21
41f9b6a
to
480a2c4
Compare
Luna-Klatzer
deleted the
669-feature-implement-assignment-to-arrays-based-on-index
branch
July 24, 2024 09:25
This was referenced Jul 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change does this PR perform?
Summary
Implemented support for index-based array assignment expressions, which allow the modification of individual parts of an array.
Closes #669
Detailed Changelog
Not present for website/docs changes
Added
BuiltInReference
, which replaces the now removed typeReference
in theKipperProgramContext
for reference tracking of built-in types.BuiltInFunction.funcType
, which returns a function type for the built-in function.FunctionDeclarationTypeSemantics.type
, which returns the type of the function declaration i.e. the function type.LambdaPrimaryExpressionTypeSemantics.type
, which returns the type of the lambda primary expression i.e. thefunction type.
Changed
compiler/.../expressions/arithmetic
toarithmetic-expression
.Fixed
Func
instead of the appropriate filled-upFunc<T..., R>
type. This now enables proper type checking for function references.Removed
Reference
as it is no longer needed and has been replaced byKipperReferenceable
.Does this PR create new warnings?
None.
Linked issues or PRs