-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the Device Activation code when users log in #3721
Comments
The whole point is you are supposed to verify the code with the one in the app to make sure no one is spying. We can’t hide it, in fact we need to show the code to verify from the modeling app |
For whoever picks this up, the oauth2 device verification code will be provided to the client we just have to show it back to them, we do this in the cli for reference |
I agree. It's like a Norman door. The page should have a single call to action that is the next step. If the user needs to verify that it matches, the button label should be "It matches" or something indicating that the user should have actually verified something before clicking. |
yeah the problem was in modeling-app we don't show them the code to verify haha but we need to! |
Yeah showing the code to the user doesn't seem straightforward to me. Right now |
Okay performing part of this splitting operation was easy. The remaining issue is that I cannot pass the |
When users log into the modeling app, they click on their OAuth provider (e.g. Google) and then sign in, and then they see this.
Users have to ignore the big code, and instead press the little continue button.
This is confusing! I still have to override my instinct to copy that code and paste it into the app somewhere. If this information is never used by the modeling app, then logging into the modeling app shouldn't show it.
We should make a second kind of login API/page which doesn't show you this code, and then the modeling app should use that instead.
The text was updated successfully, but these errors were encountered: