Show device token while signing in #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jtran
reviewed
Sep 20, 2024
jtran
reviewed
Sep 20, 2024
...ts.spec.ts-snapshots/extrude-on-default-planes-should-be-stable-XY-1-Google-Chrome-win32.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonathan Tran <[email protected]>
This reverts commit 5ba9e43.
jtran
approved these changes
Sep 20, 2024
Irev-Dev
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3721 by splitting the login functionality into two steps:
startDeviceFlowwhich sets up the device authorization handle, registers the handle for step 2 (as ahandleOncehandler), and returns theuser_codeto the frontendloginWithDeviceFlowwhich uses that previously-established handle to complete the sign-in flow.Demo
Screenshare.-.2024-09-20.11_27_01.AM-compressed.mp4