Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token.txt with device token is not actually persisting #3957

Closed
jessfraz opened this issue Sep 23, 2024 · 6 comments · Fixed by #4037
Closed

token.txt with device token is not actually persisting #3957

jessfraz opened this issue Sep 23, 2024 · 6 comments · Fixed by #4037
Labels
bug Something isn't working high-priority

Comments

@jessfraz
Copy link
Contributor

see convo here https://kittycadworkspace.slack.com/archives/C04KFV6NKL0/p1727119529732509

device tokens on the backend never expire so this must be some frontend voodoo, but adding @iterion to confirm im not hallucinating about the backend

@jessfraz jessfraz added bug Something isn't working high-priority labels Sep 23, 2024
@jessfraz jessfraz added this to the v1 Modeling App Launch milestone Sep 23, 2024
@jessfraz
Copy link
Contributor Author

adding kurt since he touched the file last @Irev-Dev

@Irev-Dev
Copy link
Collaborator

Thanks!

@jessfraz
Copy link
Contributor Author

on the backend these do expire in 14 days, we are fixing but i dont think its that, its more frequent than 14 days for me, @JordanNoone to confirm

@JordanNoone
Copy link
Contributor

I can log when it happens to be so I can confirm, but 14 days seems plausible

@iterion
Copy link
Contributor

iterion commented Sep 25, 2024

If this happens and we think it's less than 14 days we can easily verify in the database. If someone wants to let me know when it does I can check quickly and we can potentially rule out the database side.

I spot checked a few of us and prod and nobody had multiple device access tokens, but it could easily just be beyond expiry now.

@iterion
Copy link
Contributor

iterion commented Sep 25, 2024

OK, for one sessions and device access tokens were only set to last 7 days. I updated sessions to last 14 and device access tokens to last 30 days. So, if we do have a problem on the app side it should become very apparent with much longer lasting tokens.

https://github.com/KittyCAD/common/pull/1084

For tokens with longer expirations you'll need to sign in once more after this ships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants