File based settings #1679
Merged
File based settings #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
+ change the identifier back since it really doesn't seem to affect app signing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1679 +/- ##
==========================================
+ Coverage 84.64% 87.49% +2.85%
==========================================
Files 44 46 +2
Lines 18185 18946 +761
==========================================
+ Hits 15392 16577 +1185
+ Misses 2793 2369 -424
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Irev-Dev
approved these changes
Mar 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrecting my effort for file-based settings because it has some really valuable logic for falling back to defaults if invalid (or, critically, deprecated) settings values are found in the user's configs, which will allow me to safely rename the mouse control setting to "Zoo" from "KittyCAD". Likely still Tauri test fixes and other cleanup to do since we've been cranking so much the past few weeks