Add support for line, xLine, yLine, xLineTo, yLineTo #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/wasm-lib/grackle/src/native_functions/sketch/stdlib_functions.rs
Outdated
Show resolved
Hide resolved
src/wasm-lib/grackle/src/native_functions/sketch/stdlib_functions.rs
Outdated
Show resolved
Hide resolved
src/wasm-lib/grackle/src/native_functions/sketch/stdlib_functions.rs
Outdated
Show resolved
Hide resolved
adamchalmers
approved these changes
Mar 19, 2024
adamchalmers
added a commit
that referenced
this pull request
Mar 19, 2024
This reverts commit be3fed8.
Merged
adamchalmers
added a commit
that referenced
this pull request
Mar 19, 2024
CI is currently broken [logs here](https://github.com/KittyCAD/modeling-app/actions/runs/8349085118/job/22852456873?pr=1765#step:9:1046). Trying to fix. OK I've fixed it. Process to fix was: 1. Revert be3fed8 ("Add support for line, xLine, yLine, xLineTo, yLineTo (#1754)") 2. Restore that commit without any of its changes to Cargo.lock (it had, IMO, a lot of unnecessary changes) 3. `cargo update -p kittycad-execution-plan` (redoing only the necessary changes)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.