Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a feature flag to disable printlns in kcl-lib for the lsp #2712

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

jessfraz
Copy link
Contributor

closes #2468

Signed-off-by: Jess Frazelle <[email protected]>
Copy link

qa-wolf bot commented Jun 20, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jun 20, 2024 2:35am

Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (f1ef9d5) to head (f2c5ec0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2712      +/-   ##
==========================================
- Coverage   86.54%   86.54%   -0.01%     
==========================================
  Files          60       60              
  Lines       22779    22778       -1     
==========================================
- Hits        19714    19713       -1     
  Misses       3065     3065              
Flag Coverage Δ
wasm-lib 86.54% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz merged commit 4cb4867 into main Jun 20, 2024
22 of 24 checks passed
@jessfraz jessfraz deleted the lsp-disable-print branch June 20, 2024 02:38
@Irev-Dev Irev-Dev mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants