Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement from for unit length #3932

Merged
merged 1 commit into from
Sep 20, 2024
Merged

implement from for unit length #3932

merged 1 commit into from
Sep 20, 2024

Conversation

jessfraz
Copy link
Contributor

No description provided.

Signed-off-by: Jess Frazelle <[email protected]>
Copy link

qa-wolf bot commented Sep 20, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 20, 2024 0:12am

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 87.15%. Comparing base (bfac6b7) to head (1d6790e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/settings/types/mod.rs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3932      +/-   ##
==========================================
- Coverage   87.21%   87.15%   -0.07%     
==========================================
  Files          69       69              
  Lines       25103    25121      +18     
==========================================
  Hits        21894    21894              
- Misses       3209     3227      +18     
Flag Coverage Δ
wasm-lib 87.15% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz merged commit 01cc9e7 into main Sep 20, 2024
27 of 30 checks passed
@jessfraz jessfraz deleted the impl-from branch September 20, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant