Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.25.3 #3942

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Cut release v0.25.3 #3942

merged 1 commit into from
Sep 21, 2024

Conversation

Irev-Dev
Copy link
Collaborator

@Irev-Dev Irev-Dev commented Sep 21, 2024

What's Changed

Full Changelog: v0.25.2...v0.25.3

Copy link

qa-wolf bot commented Sep 21, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Sep 21, 2024 7:36am

@Irev-Dev
Copy link
Collaborator Author

Irev-Dev commented Sep 21, 2024

Manual testing Mac was good except, double click to open files from finder opens new window each time (mac/windows) didn't work. would open but always the same window

@pierremtb
Copy link
Collaborator

Windows seemed good for:
open project
export STL
new project / sketch / extrude
sign out and sign back in
change a project setting

Still seeing the menu bar popping in as the cursor get close, we have an issue for that already I believe

@Irev-Dev
Copy link
Collaborator Author

I've been able to sanity check linux, can sign in, use the app and export stuff

But lots of the FS stuff and file association I couldn't do but not sure if that's because I'm a linux noob or not.

@Irev-Dev
Copy link
Collaborator Author

The playwright tests are all failing on text-to-cad, don't know why this broken all at once. Looking at the app, it's looks like it's simply not available in the command bar??

In a way this is good because it just being gone is slightly better than being there but very broken.

@pierremtb are thinking we really need to make this release because a couple of these quirks are still better than a totally bricked app.

@Irev-Dev
Copy link
Collaborator Author

Slack thread for more details.

@Irev-Dev Irev-Dev merged commit 6e0675c into main Sep 21, 2024
19 of 24 checks passed
@Irev-Dev Irev-Dev deleted the cut-release-v0.25.3 branch September 21, 2024 13:31
@Irev-Dev
Copy link
Collaborator Author

I merged this, but as of yet have not published. With text to cad being very broken, I think rushing a release is probably not a good idea. We probably need to roll back (what must be the server side) PR that caused this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants