Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.26.0 #4196

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Cut release v0.26.0 #4196

merged 2 commits into from
Oct 18, 2024

Conversation

pierremtb
Copy link
Collaborator

@pierremtb pierremtb commented Oct 17, 2024

  • KCL bug fix: import standard library function works again
  • KCL bug fix: Permitting whitespace before colon thanks to community member @guptaarnav ❤️
  • KCL: Ranges now support arbitrary start and end values, eg. [x..100]
  • KCL breaking change: the repetitions property of all pattern functions are now instances, and now is the total count
  • KCL: Add ==, !=, >, >=, <, <= to use in if/else expressions 🎉
  • Bug fix: selection order does not matter on multi-select constraints like equal length
  • Machine API now shows additional printer info when available
  • and too many bug fixes and testing additions to list 🪨

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Oct 18, 2024 3:00pm

Copy link

qa-wolf bot commented Oct 17, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@nadr0
Copy link
Collaborator

nadr0 commented Oct 18, 2024

Grab the out-ubuntu-22.04 AppImage from the build-publish-apps job in the CI CD pipeline of the PR that has the cut release. Example scroll to the bottom and see the artifacts sections to download the file.

Gotcha: I had to chmod +x the file and install Fuse to get the AppImage running

Use: updater-test-ubuntu-22.04 from the artifacts page for the update tests.

  • Electron tests: external links open an external browser Electron tests: external links open an external browser #3373
  • coredump will open github issue with stuff populated (from home and project page) there are different ways to trigger it as well (! button at top, bug at bottom, mod + shift + .)
    • !
    • Bug bottom folder page
    • Bug bottom model render page
    • ❗ (Does not work on linux) mod + shift + .
  • running app.{app,exe} path/to/file opens the kcl file (all oses)
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/default/cube.kcl
  • running app.{app,exe} path/to/dir opens the directory and any kcl file in it or creates a main.kcl if empty (all oses)
    • Opens directory
    • Creates main file if empty
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/default
rm /home/kevin-nadro/Documents/zoo-modeling-app-projects/empty/main.kcl

/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/empty
  • If someone at the office, test you can hit make from the app and it works
  • Test updating versions works
  • until we have a performance test, sanity check that time to open file directly from command line is not shit
    • 10.36
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/Documents/zoo-modeling-app-projects/default/chassis-with-rails.kcl
/home/kevin-nadro/Downloads/Zoo\ Modeling\ App-0.25.5-x86_64-linux.AppImage /home/kevin-nadro/smoke-test-file-permissions-linux/main.kcl

Notes

  • Opening a path to a directory that doesn't exist, hangs, should we create the directory?
Loading project at startup: /home/kevin-nadro/Documents/zoo-modeling-app-projects/empty-2
Error: ENOENT: no such file or directory, stat '/home/kevin-nadro/Documents/zoo-modeling-app-projects/empty-2'
[42821:0930/142409.906556:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncParametersIfAvailable() failed for 1 times!
Checking for update
Update for version 0.25.5 is not available (latest version: 0.25.4, downgrade is disallowed).
  • Cannot figure out mod + shift + . on linux for core dump
  • Double clicking files on linux does not work.

@pierremtb
Copy link
Collaborator Author

  • Updater test on windows and macos worked
  • import on windows worked

@pierremtb pierremtb marked this pull request as ready for review October 18, 2024 16:16
@pierremtb pierremtb merged commit 2dc8b42 into main Oct 18, 2024
26 checks passed
@pierremtb pierremtb deleted the cut-release-v0.26.0 branch October 18, 2024 16:17
Copy link
Collaborator

@nadr0 nadr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants