-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor source ranges into a generic node type #4350
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
34f1d99
to
78ddf49
Compare
Signed-off-by: Nick Cameron <[email protected]>
Trying to fix TS unit test errors deserializing JSON AST in Rust.
169d2ef
to
0ec7c5c
Compare
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4350 +/- ##
==========================================
+ Coverage 85.86% 86.07% +0.21%
==========================================
Files 77 78 +1
Lines 27434 27621 +187
==========================================
+ Hits 23557 23776 +219
+ Misses 3877 3845 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, great job, this is a huge refactor, but it's worth it. Thanks so much!
It was a team effort, for sure! |
Replaces #4281. This is a step towards #4240.
This factors source ranges out of AST types and into a single
Node<T>
type. Using serde-flatten, the JSON representation and corresponding parsed JS object stay the same. This should make it much easier to add or change fields that are common to all AST nodes.