Move tests into simulation #4487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamchalmers
force-pushed
the
achalmers/move-no-vis-tests
branch
from
ea3f58b
to
7b4bf84
Compare
jtran
approved these changes
Nov 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4487 +/- ##
==========================================
+ Coverage 86.05% 86.18% +0.13%
==========================================
Files 80 80
Lines 28762 29370 +608
==========================================
+ Hits 24751 25313 +562
- Misses 4011 4057 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jtran
reviewed
Nov 15, 2024
adamchalmers
force-pushed
the
achalmers/move-no-vis-tests
branch
from
7b4bf84
to
cbdf7f8
Compare
adamchalmers
changed the title
adamchalmers
force-pushed
the
achalmers/move-no-vis-tests
branch
from
7c9e4fc
to
7339dda
Compare
adamchalmers
force-pushed
the
achalmers/move-no-vis-tests
branch
from
d8cb4dd
to
97e9bb7
Compare
|
Hmm. When serializing doubles, there's some unstable floating point math resulting in slight mismatches. |
adamchalmers
force-pushed
the
achalmers/move-no-vis-tests
branch
from
631ad4e
to
bf6040c
Compare
adamchalmers
force-pushed
the
achalmers/move-no-vis-tests
branch
from
bf6040c
to
680b381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move test cases out of the integration tests in
tests/executor, instead, move them into the simulation test framework underkcl/src/simulation_tests.rs.