Remove auto creation of the draft release #4588
Open
+13
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
pierremtb
commented
Nov 27, 2024
| @@ -148,14 +148,12 @@ This will trigger the `build-apps` workflow, set the version, build & sign the a | |||
|
|
|||
| Once the workflow succeeds, a draft release will be created at https://github.com/KittyCAD/modeling-app/releases. | |||
|
|
|||
| #### 3. Manually test artifacts from the Cut Release PR | |||
There was a problem hiding this comment.
That should have been removed before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4586
Not sure how else to work around the limit we hit during #4581 with the publish-apps-release workflow not triggered as the draft release had originally been created by github-actions and not a user. This should get us going for now with minimal user input still. README process updated too.