Refactor addFillet into addEdgeTreatment Function Supporting Chamfers #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
max-mrgrsk
requested review from
Irev-Dev,
franknoirot,
jtran,
lf94 and
nadr0
max-mrgrsk
added
feature
Co-authored-by: Kurt Hutten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the existing addFillet function into a new addEdgeTreatment function that now also supports chamfers. The function is designed to be extended to support additional edge treatments like bevels, blends, and more.
Note: I will add chamfers to the UI in a separate pull request.
Naming
I've considered the following options:
EdgeTreatment / EdgeModification / EdgeOperation / EdgeProfile
Fimfer / Chamlet / Filcham / Chamfil
EdgeTransform / EdgeMorph / BlendCut / EdgeCut
@mlfarrell, I would appreciate your input on this. @Irev-Dev mentioned that
EdgeCutis already used as a general term for fillets and chamfers on the engine side, so I'm happy to adopt this name as well. However, to me, it sounds like an existing CAD function that cuts / splits edges into pieces, whereas edge treatment is a term commonly used in metalworking and woodworking, referring to processes like chamfering or rounding edges to make them safe.Question
I would also like to rename the file, from
addFillet.tstoaddEdgeTreatment.ts. Should I do this in this pull request or in a separate one? (renaming the file will remove the diff)closes: #4527
This issue is part of the larger Fillet UI project: #2606