fix: replace whitespace with a - so that ids are valid and scroll-to works
#4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
You're correct @TomPridham this hadn't been logged to an issue yet, thank you for this! I'll review today |
franknoirot
approved these changes
Dec 9, 2024
|
Since all of the test CI items will fail on PRs opened by outside contributors, I've had to recreate this PR as #4710. I'll close this and get that in. Sorry for the runaround Tom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find an existing issue. I noticed the scrollto behavior didn't work for keybind settings that included whitespace because they were generating invalid ids, e.g.
id="categoryCommand Palette". It isn't a problem for the User settings because the display strings weredecamelizedobject propertiesbefore:
Screencast from 2024-11-27 13-30-48.webm
after:
Screencast from 2024-11-27 13-32-29.webm