Add in the basics for Import ordering #5524
Open
+228
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will walk AST for import notes, and build up a mapping of relationships tying in the target of the import (the "dependency") to our current program (the "dependent"). This allows us to build up a mapping of what dependency and reverse dependency relationships look like, in order to sort dependencies by topologically sorting them. Since I wanted to enable some parallelism here long-term, this returns the (kinda awkward) `Vec<Vec<String>>` type. This is a list of list of dependency targets which can safely be run concurrently, because they have no dependency relationship to eachother. Each list of dependencies should be gated, and start the next list of dependencies after the first is complely done. This isn't ideal and will change long-term, but for now this will work to enable very basic opportunistic parallelism.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
this lint doesn't apply here, order doesn't matter. Elsewhere in this program where order does matter we do the intermediate vec.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5524 +/- ##
==========================================
+ Coverage 86.32% 86.37% +0.05%
==========================================
Files 95 96 +1
Lines 36020 36170 +150
==========================================
+ Hits 31093 31241 +148
- Misses 4927 4929 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jessfraz
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will walk AST for import notes, and build up a mapping of relationships tying in the target of the import (the "dependency") to our current program (the "dependent").
This allows us to build up a mapping of what dependency and reverse dependency relationships look like, in order to sort dependencies by topologically sorting them.
Since I wanted to enable some parallelism here long-term, this returns the (kinda awkward)
Vec<Vec<String>>type.This is a list of list of required AST files which can safely be run concurrently, because they have no dependency relationship to eachother. Each list of dependencies should be fenced, and start the next list of dependencies after the first is complely done. This isn't ideal and will change long-term, but for now this will work to enable very basic opportunistic parallelism.