Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better errors from rust to lsp for execution errors #5526

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Feb 26, 2025

  • todo make miette errors handle multiple files
  • lsp test for multiple files

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app 🔄 Building (Inspect) Visit Preview Feb 26, 2025 11:39pm

Copy link

qa-wolf bot commented Feb 26, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.28%. Comparing base (725c4d9) to head (1a83576).

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/errors.rs 84.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5526      +/-   ##
==========================================
- Coverage   86.29%   86.28%   -0.01%     
==========================================
  Files          95       95              
  Lines       35952    35990      +38     
==========================================
+ Hits        31025    31055      +30     
- Misses       4927     4935       +8     
Flag Coverage Δ
wasm-lib 86.28% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz marked this pull request as ready for review February 26, 2025 21:27
@jessfraz jessfraz marked this pull request as draft February 26, 2025 21:27
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant