Skip to content

Fixing comments and descriptions in samples #7466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/kcl-samples/axial-fan/main.kcl
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// PC Fan
// Axial Fan
// A small axial fan, used to push or draw airflow over components to remove excess heat

// Set units
Expand Down
2 changes: 1 addition & 1 deletion public/kcl-samples/countersunk-plate/main.kcl
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ centerHoleDiameter = 1 + 3 / 4
plateThickness = 0.375

// Check that the plate is thick enough to countersink a hole
// assertGreaterThan(plateThickness, boltDiameter, "This plate is not thick enough for the necessary countersink dimensions")
assert(plateThickness, isGreaterThan = boltDiameter, error = "This plate is not thick enough for the necessary countersink dimensions")

// A bit of math to calculate the tangent line between the two diameters
r1 = centerHoleDiameter / 2 * 1.5 + .35
Expand Down
4 changes: 2 additions & 2 deletions public/kcl-samples/manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"file": "main.kcl",
"pathFromProjectDirectoryToFirstFile": "axial-fan/main.kcl",
"multipleFiles": true,
"title": "PC Fan",
"title": "Axial Fan",
"description": "A small axial fan, used to push or draw airflow over components to remove excess heat",
"files": [
"fan-housing.kcl",
Expand Down Expand Up @@ -667,7 +667,7 @@
"pathFromProjectDirectoryToFirstFile": "t-slot-rail/main.kcl",
"multipleFiles": false,
"title": "T-Slotted Framing Rail",
"description": "A T-slotted framing rail, or T-slot extrusion, is a rectangular or square aluminum profile with a \"T\" shaped slot along one or more sides. These slots allow for easy attachment of various hardware components like brackets, connectors, and fasteners, making it a versatile and customizable framing system.",
"description": "A T-slotted framing rail, commonly known as an 80/20 rail, is a rectangular or square aluminum extrusion with a \"T\" shaped slot along one or more sides. These slots allow for easy attachment of various hardware components like brackets, connectors, and fasteners, making it a versatile and customizable framing system.",
"files": [
"main.kcl"
]
Expand Down
Binary file modified public/kcl-samples/screenshots/ball-joint-rod-end.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion public/kcl-samples/t-slot-rail/main.kcl
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// T-Slotted Framing Rail
// A T-slotted framing rail, or T-slot extrusion, is a rectangular or square aluminum profile with a "T" shaped slot along one or more sides. These slots allow for easy attachment of various hardware components like brackets, connectors, and fasteners, making it a versatile and customizable framing system.
// A T-slotted framing rail, commonly known as an 80/20 rail, is a rectangular or square aluminum extrusion with a "T" shaped slot along one or more sides. These slots allow for easy attachment of various hardware components like brackets, connectors, and fasteners, making it a versatile and customizable framing system.

// Set units
@settings(defaultLengthUnit = in, kclVersion = 1.0)
Expand Down
2 changes: 1 addition & 1 deletion rust/kcl-lib/tests/kcl_samples/axial-fan/ast.snap
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ description: Result of parsing axial-fan.kcl
"type": "Identifier"
},
"preComments": [
"// PC Fan",
"// Axial Fan",
"// A small axial fan, used to push or draw airflow over components to remove excess heat",
"",
"",
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -95,16 +95,16 @@ flowchart LR
9 --- 36
10 --- 22
10 x--> 25
10 --- 32
10 --- 38
10 --- 29
10 --- 35
11 --- 23
11 x--> 25
11 --- 33
11 --- 39
12 --- 24
12 x--> 25
12 --- 29
12 --- 35
12 --- 32
12 --- 38
14 --- 19
14 x--> 27
14 --- 28
Expand Down Expand Up @@ -138,15 +138,15 @@ flowchart LR
21 --- 30
21 --- 36
37 <--x 21
22 --- 32
22 --- 38
39 <--x 22
22 --- 29
22 --- 35
36 <--x 22
23 --- 33
35 <--x 23
23 --- 39
24 --- 29
24 --- 35
36 <--x 24
24 --- 32
24 --- 38
39 <--x 24
28 <--x 26
29 <--x 27
30 <--x 27
Expand Down
Loading
Loading