-
Notifications
You must be signed in to change notification settings - Fork 77
Add building the artifact graph in sketch mode, take 2 #7557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ebd5aa0
to
5859239
Compare
CodSpeed Instrumentation Performance ReportMerging #7557 will not alter performanceComparing Summary
|
Great to see this! I did check the issue mentioned here which is still occurring but I think that's because we still pass an outdated sketchDetails.sketchNodePaths to |
Resolves #5166. Replaces #5093.
Thanks to #5068, we can build the majority of the artifact graph without the engine. I verified that the graph gets built without exiting sketch mode.
Note: Mock UUIDs don't match real UUIDs. From past conversations, we think this is desirable. But I'm not actually sure why it is different. Unlike #5093, I didn't make a new, separate
IdGenerator
.I made a Rust-side test, but not a TS-side test. It isn't user-facing. Presumably, whatever user-facing feature that relies on this will get tested.
We remove
skip_serializing_if
because emptyVec
s are getting used for the first time in this PR, and that's causing a TS runtime error. Aleph-Alpha/ts-rs#393 fixes the TS types to reflect that. We need to upgrade to ts-rs v11.0. Until then, just don't skip.