fix(layers): fix initialization bugs when less than all views mounted #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
floryst
reviewed
Oct 31, 2023
src/store/view-configs/layers.ts
Outdated
| location: 'pointData', | ||
| }); | ||
| setColorPreset(viewID, dataID, getPreset(dataID)); | ||
| const defaultColorPreset = (viewID: string, layerID: LayerID) => { |
There was a problem hiding this comment.
I think this would be better named as resetToDefault, or at least have the verb reset in the name.
There was a problem hiding this comment.
Yes, changed to resetColorPreset
If configured for axial only view, then add a layer, layer properties GUI would just try to get first view config (Sagittal?), which did not exist. If a layer was created, without the view mounted, the colorBy layer config would not be set, and the layer would be invisible.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If configured for axial only view, then add a layer, layer properties GUI would just try to get first view config (Sagittal?), which did not exist.
If a layer was created, without the view mounted, the colorBy layer config would not be set, and the layer would be invisible.