Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Slice): Use keyboard to change slices of the active view #679

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

lchauvin
Copy link
Contributor

This needs this PR to be merged first: #676

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a38efeb
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/6789363eb42d800008f36000
😎 Deploy Preview https://deploy-preview-679--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PaulHax PaulHax self-requested a review December 12, 2024 14:09
Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making dreams come true here.

If you rebase on top of main rather than merge we can avoid thoes pesky merge commits.

src/composables/actions.ts Outdated Show resolved Hide resolved
src/components/LayoutGrid.vue Outdated Show resolved Hide resolved
@lchauvin lchauvin force-pushed the keyboard-change-slice branch from 01402f2 to a38efeb Compare January 16, 2025 16:39
@PaulHax PaulHax self-requested a review January 16, 2025 16:47
Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great feels great. Been wanting this!

@PaulHax PaulHax requested a review from floryst January 16, 2025 18:12
Copy link
Collaborator

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this!

@floryst floryst added this pull request to the merge queue Jan 20, 2025
Merged via the queue into Kitware:main with commit 17ea21e Jan 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants