fix(View): Allow method call from prop change

Kitware · Jan 27, 2021 · e2c57e8 · e2c57e8
1 parent 931acac
commit e2c57e8
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/core/GeometryRepresentation.js b/src/core/GeometryRepresentation.js
@@ -61,7 +61,7 @@ export default class GeometryRepresentation extends Component {
 
   componentWillUnmount() {
     if (this.view) {
-      this.view.renderer.remoteActor(this.actor);
+      this.view.renderer.removeActor(this.actor);
     }
 
     this.actor.delete();

diff --git a/src/core/View.js b/src/core/View.js
@@ -219,6 +219,8 @@ export default class View extends Component {
       cameraPosition,
       cameraViewUp,
       cameraParallelProjection,
+      triggerRender,
+      triggerResetCamera,
     } = props;
     if (background && (!previous || background !== previous.background)) {
       this.renderer.setBackground(background);
@@ -256,6 +258,14 @@ export default class View extends Component {
         this.resetCamera();
       }
     }
+
+    // Allow to trigger method call from property change
+    if (previous && triggerRender !== previous.triggerRender) {
+      setTimeout(this.renderView, 0);
+    }
+    if (previous && triggerResetCamera !== previous.triggerResetCamera) {
+      setTimeout(this.resetCamera, 0);
+    }
   }
 
   resetCamera() {
@@ -272,6 +282,8 @@ View.defaultProps = {
   cameraPosition: [0, 0, 1],
   cameraViewUp: [0, 1, 0],
   cameraParallelProjection: false,
+  triggerRender: 0,
+  triggerResetCamera: 0,
   interactorSettings: [
     {
       button: 1,
@@ -342,6 +354,16 @@ View.propTypes = {
    */
   cameraParallelProjection: PropTypes.bool,
 
+  /**
+   * Property use to trigger a render when changing.
+   */
+  triggerRender: PropTypes.number,
+
+  /**
+  * Property use to trigger a resetCamera when changing.
+  */
+  triggerResetCamera: PropTypes.number,
+
   /**
    * List of representation to show
    */