test: Update tests that now fail

The normals have been fixed in the shader, hence the difference Also the sample distance is not computed in index space anymore This explains some differences
Kitware · Oct 4, 2024 · dd4af97 · dd4af97
1 parent 4a51712
commit dd4af97
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 6 deletions.
diff --git a/Sources/Rendering/Core/VolumeMapper/test/testColorMix.js b/Sources/Rendering/Core/VolumeMapper/test/testColorMix.js
@@ -142,7 +142,7 @@ test('Test Volume Rendering: custom shader code', async (t) => {
           if (opacity1 > 0.5) {
             return vec4(0.0, 1.0, 1.0, 0.1);
           } else {
-            vec3 posIS = VCtoIS(posVC);
+            vec3 posIS = posVCtoIS(posVC);
             mat4 normalMat = computeMat4Normal(posIS, tValue);
             float opacity0 = getOpacityFromTexture(tValue[0], 0, volume.transferFunctionsSampleHeight[0]);
             vec3 color0 = getColorFromTexture(tValue[0], 0, volume.transferFunctionsSampleHeight[0]);

diff --git a/Sources/Rendering/Core/VolumeMapper/test/testColorMixAdditive.png b/Sources/Rendering/Core/VolumeMapper/test/testColorMixAdditive.png
diff --git a/Sources/Rendering/Core/VolumeMapper/test/testColorMixColorize.png b/Sources/Rendering/Core/VolumeMapper/test/testColorMixColorize.png
diff --git a/Sources/Rendering/Core/VolumeMapper/test/testColorMixCustom.png b/Sources/Rendering/Core/VolumeMapper/test/testColorMixCustom.png
diff --git a/Sources/Rendering/OpenGL/VolumeMapper/index.js b/Sources/Rendering/OpenGL/VolumeMapper/index.js
@@ -112,11 +112,10 @@ function vtkOpenGLVolumeMapper(publicAPI, model) {
   }
 
   function unregisterGraphicsResources(renderWindow) {
-    graphicsResourceReferenceCount
-      .keys()
-      .forEach((coreObject) =>
-        renderWindow.unregisterGraphicsResourceUser(coreObject, publicAPI)
-      );
+    // Convert to an array using the spread operator as Firefox doesn't support Iterator.forEach()
+    [...graphicsResourceReferenceCount.keys()].forEach((coreObject) =>
+      renderWindow.unregisterGraphicsResourceUser(coreObject, publicAPI)
+    );
   }
 
   publicAPI.buildPass = () => {

diff --git a/Sources/Rendering/OpenGL/VolumeMapper/test/testVolumeMapperShadowClip.png b/Sources/Rendering/OpenGL/VolumeMapper/test/testVolumeMapperShadowClip.png