Update to v29 #2946
Merged
Update to v29 #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors WebXR rendering support. Under previous behavior WebXR rendering was embedded in vtkOpenGLRenderWindow. This change removes the dependency of vtkOpenGLRenderWindow on WebXR and moves XR components into vtkWebXRRenderWindowHelper. The helper class holds a reference to an underlying render window and is responsible to start/run/stop XR rendering. BREAKING CHANGE: Removes WebXR API from `vtkOpenGLRenderWindow`. Applications requiring XR support must instantiate `vtkWebXRRenderWindowHelper` instead.
Updates WebXR examples for refactoring to `vtkWebXRRenderWindowHelper`.
Replaces `global` definition of XRGLLayer with imported definition from `window`. Addresses observed issue in VolView development where the `global` definition is not yet available at call time.
…pplication logic Updates `vtkWebXRRenderWindowHelper` interface to expose the underlying XR session and to emit the VTK "modified" event when state changes. Motivated by subsequent VolView application development.
…nd public interface Improves TypeScript definitions and removes previous publicAPI methods for setting the XR session and rendering an XR frame. Motivated by subsequent application development in VolView.
Add WebXR TypeScript definitions to vtkWebXRRenderWindowHelper to resolve CI failures.
BREAKING CHANGE: remove deprecated widget manager APIs
BREAKING CHANGE: LineWidget is favored over the distance widget.
With WebGPU, moving the mouse over was triggering many errors due to asynchronous captureBuffer calls
Allow passing defaultViewAPI in vtkFullscreenRenderWindow newInstance. vtkFullscreenRenderWindow, vtkGenericRenderWindow and vtkViewProxy are now exposing `getApiSpecificRenderWindow()` instead of `getOpenGLRenderWindow()`. `OpenGL/vtkBufferObject` and `OpenGL/vtkHardwareSelector` still expose `getOpenGLRenderWindow()`.
Refactor WebXR Rendering to `vtkWebXRRenderWindowHelper`
fix(webgpu): Fix support of WebGPU render backend
feat(WidgetManager): remove deprecated APIs
refactor: drop DistanceWidget
tbirdso
approved these changes
Oct 26, 2023
|
🎉 This PR is included in version 29.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the
BREAKING_CHANGES.mddoc and the v29 milestone for info on the details of this breaking change.