Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix imagemapper blending and rerendering #3165

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix imagemapper blending and rerendering #3165

merged 2 commits into from
Nov 6, 2024

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Nov 4, 2024 •
edited
Loading

Context

Two issues:

  1. Constant label outline thickness texture re-uploads when nothing changes
  2. Incorrect blending between two labelmaps with label outline turned on
  • I am not yet sure if there is an underlying bug in the OIT implementation, and I haven't spent the time to debug this further. The second commit fixes the issue with minimal changes.

FYI @sedghi

Results

  • Only update the label outline thickness texture when the underlying array reference actually changes
  • Blending two labelmaps with label outline on works.

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

@floryst
fix(ImageMapper): unstable resource reference
b8c6162 
Array getters by default return a copy of the underlying array.
labelOutlineThicknessArray is used as a key in a map to detect changes,
so use a reference to the underlying array instead of a copy.
@floryst
fix(ImageMapper): blend against black, not cyan
9f8689c
@floryst floryst added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit 8c73b70 Nov 6, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 32.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@floryst