Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export interface IPosition in Rendering/Core/RenderWindowInteractor #3166

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Export interface IPosition in Rendering/Core/RenderWindowInteractor #3166

merged 1 commit into from
Nov 6, 2024

Conversation

jeremygau
Copy link
Contributor

Context

fix #3164
interface IPosition is exported solving the issue variable x has or is using the name IPosition from the external module @kitware/vtk.js/Rendering/Core/RenderWindowInteractor, but it cannot be named

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@jeremygau jeremygau mentioned this pull request Nov 4, 2024
Closed
finetjul
finetjul approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremygau
Copy link
Contributor Author

Hello
Can someone explain why the PR checks fail ?
Thanks

@floryst
Copy link
Collaborator

floryst commented Nov 5, 2024

Your commit message should conform to angular commit conventions. If you reword your commit to fix(RenderWindowInteractor): export IPosition and force-push then the PR checks will pass.

@jeremygau jeremygau force-pushed the bugfix/export-IPosition branch from c906c10 to 10e8177 Compare November 5, 2024 20:10
@jeremygau
Copy link
Contributor Author

Your commit message should conform to angular commit conventions. If you reword your commit to fix(RenderWindowInteractor): export IPosition and force-push then the PR checks will pass.

Thanks
That's what I did but the force push did not pass 😅
Anyway it should be good now

@floryst floryst added this pull request to the merge queue Nov 6, 2024
Merged via the queue into Kitware:master with commit 1ca5ba1 Nov 6, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 32.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] IPosition not exported from @kitware/vtk.js/Rendering/Core/RenderWindowInteractor
3 participants
@jeremygau @floryst @finetjul