Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GLTFImporter): fix the environment texture path #3176

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(GLTFImporter): fix the environment texture path #3176

merged 1 commit into from
Nov 20, 2024

Conversation

daker
Copy link
Collaborator

@daker daker commented Nov 13, 2024 •
edited
Loading

Context

Fix the environment texture path

image

Results

image

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker
Copy link
Collaborator Author

daker commented Nov 13, 2024

@floryst mind looking ?

finetjul
finetjul approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daker
Copy link
Collaborator Author

daker commented Nov 19, 2024

@floryst mind merging this fix ?

@floryst floryst added this pull request to the merge queue Nov 20, 2024
Merged via the queue into Kitware:master with commit 9ab3172 Nov 20, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 32.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Nov 20, 2024
@daker daker deleted the fix-gltf-example branch November 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryst floryst floryst approved these changes

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daker @finetjul @floryst