Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GLTFImporter): add support for multiple primitives #3181

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix(GLTFImporter): add support for multiple primitives #3181

merged 1 commit into from
Nov 26, 2024

Conversation

daker
Copy link
Collaborator

@daker daker commented Nov 24, 2024 •
edited
Loading

Context

This PR adds support for multiple primitives

Actual behavior

Results

Before After
before after

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@daker daker marked this pull request as ready for review November 24, 2024 22:46
finetjul
finetjul reviewed Nov 25, 2024
View reviewed changes
Sources/IO/Geometry/GLTFImporter/Reader.js Show resolved Hide resolved
Sources/IO/Geometry/GLTFImporter/Reader.js Outdated Show resolved Hide resolved
Sources/IO/Geometry/GLTFImporter/Reader.js Outdated Show resolved Hide resolved
@daker daker force-pushed the gltf-multiprimitives branch 2 times, most recently from 29c6450 to e63a107 Compare November 25, 2024 23:42
finetjul
finetjul reviewed Nov 26, 2024
View reviewed changes
Sources/IO/Geometry/GLTFImporter/Reader.js Outdated Show resolved Hide resolved
Sources/IO/Geometry/GLTFImporter/Reader.js Outdated Show resolved Hide resolved
Sources/IO/Geometry/GLTFImporter/Reader.js Outdated Show resolved Hide resolved
@daker daker force-pushed the gltf-multiprimitives branch from e63a107 to d11e6bb Compare November 26, 2024 13:23
finetjul
finetjul approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul added this pull request to the merge queue Nov 26, 2024
Merged via the queue into Kitware:master with commit 34d5078 Nov 26, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 32.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daker @finetjul