Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vtkXMLPolyDataWriter Support Save FieldData #3187

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: vtkXMLPolyDataWriter Support Save FieldData #3187

merged 1 commit into from
Dec 13, 2024

Conversation

wumanman1024
Copy link
Contributor

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@wumanman1024 wumanman1024 mentioned this pull request Dec 12, 2024
Closed
finetjul
finetjul approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul added this pull request to the merge queue Dec 13, 2024
Merged via the queue into Kitware:master with commit 89758ed Dec 13, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 32.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wumanman1024 @finetjul