refactor(OpenGL/Texture): use named parameters #3224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floryst
force-pushed
the
opengltexture-named-parameters
branch
2 times, most recently
from
b820050 to
b7fdd20
Compare
|
FYI @sedghi |
|
Looks great! |
floryst
force-pushed
the
opengltexture-named-parameters
branch
from
b7fdd20 to
ecfb22b
Compare
add computeRanges arg. If set to false will clone the existing range. If true, will calculate the ranges. Added the magnitude ranges for multi-component ranges
…compareFloat added test for getRanges(false)
makes create3DFilterableFromRaw consistent with create2DFilterableFromRaw
…ulti-component magnitude
vtkVolumeMapper, vtkImageCPRMapper, and vtkImageResliceMapper all now support updating sub-image extents, reducing the GPU upload overhead when part of the image has updated.
Init pickFromList to false not 0. Fix TypeScript defs.
This change adds support for sorting 2D actor overlays based on their `layerNumber` property.
This ensures that they are rendered in the correct order for every frame even if their layer number changes between frames.
This change adds an argument to `addMissingNodes` to ensure that the view node ordering is maintained. By default, ordering is not maintained. However, for nodes of type `vtkActor2D`, where layering requires a specific order, the node ordering is enforced.
floryst
force-pushed
the
opengltexture-named-parameters
branch
2 times, most recently
from
9c33a0a to
caf8081
Compare
BREAKING CHANGE: the updatedExtent API has been moved from the mappers to the vtkImageProperty and vtkVolumeProperty interfaces. vtkImageMapper does not yet honor the updatedExtent API.
floryst
force-pushed
the
opengltexture-named-parameters
branch
from
caf8081 to
8e7e117
Compare
The create* methods have enough parameters to warrant using named parameters. BREAKING CHANGE: the create* methods now use named parameters rather than positional parameters.
floryst
force-pushed
the
opengltexture-named-parameters
branch
from
8e7e117 to
281b5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The create* methods have enough parameters to warrant using named parameters.
Closes #3222
Results
create*methods now use named parametersChanges
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting