Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Make NSIS Windows installer prettier with application branding #93

Merged

Conversation

jamesobutler
Copy link
Contributor

@jamesobutler jamesobutler commented Jan 28, 2025

This should be integrated only once the corresponding Slicer PR has been integrated:

Note

Below are mockup screenshots of what the installer would look like. These are mockups and have some carry over content from a regular Slicer installer, but was done to avoid having to build a SlicerCustomAppTemplate from scratch. I have independently confirmed that a Slicer custom app can have its installer successfully customized in this way with its own branding.

kitware-installer-welcome-mockup
kitware-installer-header-mockup

cc: @jcfr

@jcfr
Copy link
Collaborator

jcfr commented Jan 28, 2025

Thanks for the contribution 🙏 , this will be a great improvement.

Detailed review has been posted at Slicer/Slicer#8192 (review)

@jamesobutler jamesobutler force-pushed the installer-application-branding branch from 3fa1c24 to a567281 Compare January 29, 2025 21:49
@jamesobutler jamesobutler changed the title ENH: Make installer prettier with application branding ENH: Make NSIS Windows installer prettier with application branding Jan 29, 2025
As of Slicer/Slicer@f869775, there is customization for application branding in the Windows NSIS installer.
@jamesobutler jamesobutler force-pushed the installer-application-branding branch from a567281 to 352302a Compare January 29, 2025 23:26
@jamesobutler jamesobutler marked this pull request as ready for review January 29, 2025 23:26
@jamesobutler
Copy link
Contributor Author

@jcfr I've updated the commit message body linking to the Slicer commit which added the NSIS installer branding customization.

@jcfr jcfr merged commit 976320d into KitwareMedical:main Jan 30, 2025
4 checks passed
@jcfr
Copy link
Collaborator

jcfr commented Jan 30, 2025

Thanks for not only updating Slicer but for also updating the SlicerCustomAppTemplate 🙏 💯

@jamesobutler jamesobutler deleted the installer-application-branding branch January 30, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants