Convert CLIs from C++ CLIs to Python Scripted modules + add BackScatterCoefficient module #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtkImageData needs to have identity information for use in a node https://discourse.slicer.org/t/installing-itk-python-package-in-slicer-5-1-and-above/25636
This module houses common functionality for a few scan conversion modules.
Start ScanConvertPhasedArray3D by copying ScanConvertCurvilinearArray Split lateral separation parameter into azimuth and elevation Update input image information Update test Require itk-ultrasound 0.6.2 for PA3DSCI wrapping
Do not reference non-existent UI resource for ITKUltrasoundCommon Add ScanConvertCommon to the extension's list of modules Rename ScanConvertCommon.png
…rray Bump itk-ultrasound version number to include InsightSoftwareConsortium/ITK#4142
…xt manager Start with Slicer/Slicer@19d2cbe4c (ENH: Add context managers for message and error display to slicer.util) introduced in Slicer 5.0, the slicer.util.WaitCursor context manager implements the corresponding functionality.
This commit removes the following functions originally introduced in 1fdd2f8 (ENH: BMode filter works): * get_rotation_and_spacing_from_affine * get_itk_metadata_from_ras_affine * get_ras_affine_from_itk
|
Thanks for your work on this. This is no longer at the top of my priority list, so it will take a while for me to return to this work and finish this refactoring. Let's keep this PR open until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request depends on:
Module Updates
GenerateBModeFromRF)Also added support modules: