Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Update vtkRenderingLookingGlass to fix "Portrait" support #25

Merged

Conversation

jcfr
Copy link
Contributor

@jcfr jcfr commented Nov 1, 2022

  • Update vtkRenderingLookingGlass to include recent fixes, which adds support for the Looking Glass Portrait.

  • Remove HoloPlayCore external project and instead use the "FetchHoloPlayCore" module available in vtkRenderingLookingGlass.

List of vtkRenderingLookingGlass changes:

$ git shortlog f3b4c8928..23cd56032 --no-merges
Chris Harris (21):
      Add static map to store device settings
      Add new member to hold the device type
      Add method to look up setting for a give device
      Use device type to setup quilt
      Don't default quilt settings
      Add method to return list of available devices
      Deprecate "quilt quality"
      Remove unnecessary variable
      Remove QuiltExportMagnification
      Fix formatting
      Add pyproject.toml
      Add skeleton setup.py
      Switch author to 'VTK developers'
      Add vtk to install_requires
      Switch to setuptools_scm for version
      Switch to upstream VTKExternalModule
      Bump SDK version and VTK verson to 9.2.0rc1
      Bump to vtk rc2
      Skip python 3.11 for now
      Bump VTK version
      Update platform suffix for macosx

Jean-Christophe Fillion-Robin (1):
      COMP: Streamline client project integration by explicitly including "vector"

Mathieu Westphal (1):
      Clarifying license and using new license mechanism from VTK

Patrick Avery (45):
      Add ability to save quilt images and movies
      Add magnification factor for exporting quilts
      Change ogg extension to ogv
      Put common render code in a RenderQuilt() function
      Add `renderers` argument to RenderQuilt()
      Remove off screen buffer usage from RenderQuilt()
      Save quilts via textures, not the render window
      Add python API and examples for saving quilts
      Add quilt file suffix to example file names
      Fix import paths in python examples
      Remove MP4 requirement for Windows
      Set up wheel building infrastructure
      Also install HoloPlayCore runtime library
      Automatically download VTK SDK for platform
      Do not download VTK SDK in GitHub actions
      Fix Mac SDK URL for python > 3.9
      Allow install path selection for the VTK wheel SDK
      Add wheel repair step for Linux
      Remove the VTK wheel SDK before every Linux build
      Keep the same RECORD file from before wheel repair
      Add several functions to the render window
      Add an example of changing devices
      Add Linux environment variable for dev building
      Fix transparent background issue for quilt images
      Add basic import test for all of the wheels
      Update looking glass device names
      Add thorax_kidneys example
      Keep track of device aspect ratios
      Replace hpc_TeardownMessagePipe with hpc_CloseApp
      Fix a few compiler warnings
      Add instructions for running C++ tests
      Add head and neck example of cinematic rendering (PR-46)
      Update Looking Glass Core to latest version
      Build arm64 wheels for macos
      Use arm64 VTK wheel SDK when building arm64 wheels
      Skip cp38-macosx_arm64 wheels
      Add platform_suffix to VTK SDK dir cache
      Upload skbuild if an error occurred
      Also check if the machine is arm64
      Define CMAKE_SYSTEM_NAME if cross-compiling
      Add -DVTK_USE_COCOA definition
      Turn off arm64 builds in cibuildwheel
      Downgrade the LookingGlass SDK that Linux uses
      Add Python package info to README.md
      Add settings for 65" device

Stephen Aylward (1):
      ENH: Adding a Looking Glass rendering example in Python (jupyter)

Stephen R. Aylward (6):
      BUG: Copy FindHoloPlayCore into VTK build tree
      Update CMakeLists.txt
      ENH: Provide hints for finding HoloPlayCore
      ENH: RenderingLookingGlass now requires vtkMP4Writer to save quilts
      ENH: Provide clearer instructions on required components (PR-29)
      COMP: Portrait device playlists only support the yuv420p colormap (PR-60)

* Update vtkRenderingLookingGlass to include recent fixes, which adds
  support for the Looking Glass Portrait.

* Remove HoloPlayCore external project and instead use the "FetchHoloPlayCore"
  module available in vtkRenderingLookingGlass.

List of vtkRenderingLookingGlass changes:

$ git shortlog f3b4c8928..23cd56032 --no-merges
Chris Harris (21):
      Add static map to store device settings
      Add new member to hold the device type
      Add method to look up setting for a give device
      Use device type to setup quilt
      Don't default quilt settings
      Add method to return list of available devices
      Deprecate "quilt quality"
      Remove unnecessary variable
      Remove QuiltExportMagnification
      Fix formatting
      Add pyproject.toml
      Add skeleton setup.py
      Switch author to 'VTK developers'
      Add vtk to install_requires
      Switch to setuptools_scm for version
      Switch to upstream VTKExternalModule
      Bump SDK version and VTK verson to 9.2.0rc1
      Bump to vtk rc2
      Skip python 3.11 for now
      Bump VTK version
      Update platform suffix for macosx

Jean-Christophe Fillion-Robin (1):
      COMP: Streamline client project integration by explicitly including "vector"

Mathieu Westphal (1):
      Clarifying license and using new license mechanism from VTK

Patrick Avery (45):
      Add ability to save quilt images and movies
      Add magnification factor for exporting quilts
      Change ogg extension to ogv
      Put common render code in a RenderQuilt() function
      Add `renderers` argument to RenderQuilt()
      Remove off screen buffer usage from RenderQuilt()
      Save quilts via textures, not the render window
      Add python API and examples for saving quilts
      Add quilt file suffix to example file names
      Fix import paths in python examples
      Remove MP4 requirement for Windows
      Set up wheel building infrastructure
      Also install HoloPlayCore runtime library
      Automatically download VTK SDK for platform
      Do not download VTK SDK in GitHub actions
      Fix Mac SDK URL for python > 3.9
      Allow install path selection for the VTK wheel SDK
      Add wheel repair step for Linux
      Remove the VTK wheel SDK before every Linux build
      Keep the same RECORD file from before wheel repair
      Add several functions to the render window
      Add an example of changing devices
      Add Linux environment variable for dev building
      Fix transparent background issue for quilt images
      Add basic import test for all of the wheels
      Update looking glass device names
      Add thorax_kidneys example
      Keep track of device aspect ratios
      Replace hpc_TeardownMessagePipe with hpc_CloseApp
      Fix a few compiler warnings
      Add instructions for running C++ tests
      Add head and neck example of cinematic rendering (PR-46)
      Update Looking Glass Core to latest version
      Build arm64 wheels for macos
      Use arm64 VTK wheel SDK when building arm64 wheels
      Skip cp38-macosx_arm64 wheels
      Add platform_suffix to VTK SDK dir cache
      Upload skbuild if an error occurred
      Also check if the machine is arm64
      Define CMAKE_SYSTEM_NAME if cross-compiling
      Add -DVTK_USE_COCOA definition
      Turn off arm64 builds in cibuildwheel
      Downgrade the LookingGlass SDK that Linux uses
      Add Python package info to README.md
      Add settings for 65" device

Stephen Aylward (1):
      ENH: Adding a Looking Glass rendering example in Python (jupyter)

Stephen R. Aylward (6):
      BUG: Copy FindHoloPlayCore into VTK build tree
      Update CMakeLists.txt
      ENH: Provide hints for finding HoloPlayCore
      ENH: RenderingLookingGlass now requires vtkMP4Writer to save quilts
      ENH: Provide clearer instructions on required components (PR-29)
      COMP: Portrait device playlists only support the yuv420p colormap (PR-60)

Co-authored-by: Kyle Sunderland <[email protected]>
@jcfr jcfr linked an issue Nov 1, 2022 that may be closed by this pull request
@jcfr jcfr merged commit bd9fec8 into master Nov 1, 2022
@jcfr jcfr deleted the update-vtkRenderingLookingGlass-to-fix-portrait-support branch November 1, 2022 04:51
@jcfr jcfr linked an issue Nov 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LookingGlass module is not loaded Distorted view with Looking Glass Portrait LGP and Slicer 3D + Extention
1 participant