Response status for mollie webhook and finish slack message

KjellBerlin · Aug 30, 2024 · 1d41f1f · 1d41f1f
1 parent 6c4f85f
commit 1d41f1f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/src/main/kotlin/com/carbonara/core/payment/MolliePaymentWebhookController.kt b/src/main/kotlin/com/carbonara/core/payment/MolliePaymentWebhookController.kt
@@ -2,6 +2,7 @@ package com.carbonara.core.payment
 
 import com.carbonara.core.order.OrderService
 import mu.KotlinLogging
+import org.springframework.http.ResponseEntity
 import org.springframework.web.bind.annotation.PostMapping
 import org.springframework.web.bind.annotation.RestController
 
@@ -11,12 +12,12 @@ class MolliePaymentWebhookController(
 ) {
 
     // Potential dos attack endpoint, introduce rate limiting
-    // TODO: Add response status
 
-    @PostMapping("/mollie-payment-status", "application/x-www-form-urlencoded")
-    suspend fun handleMollieWebhook(requestBody: MollieWebhookRequestBody) {
+    @PostMapping("/mollie-payment-status", consumes = ["application/x-www-form-urlencoded"])
+    suspend fun handleMollieWebhook(requestBody: MollieWebhookRequestBody): ResponseEntity<Void> {
         log.info("Webhook received for paymentId: {}", requestBody.id)
         orderService.handleOrderPayment(requestBody.id)
+        return ResponseEntity.ok().build()
     }
 
     companion object {

diff --git a/src/main/kotlin/com/carbonara/core/slack/SlackMessageService.kt b/src/main/kotlin/com/carbonara/core/slack/SlackMessageService.kt
@@ -26,14 +26,6 @@ class SlackMessageService {
         val response = slack.methods(slackToken).chatPostMessage { req -> req
             .channel(slackChannel)
             .blocks {
-                section {
-                    markdownText("*New Order*")
-                }
-                /*
-                header {
-                    plainText("New order")
-                }
-                */
                 section {
                     fields {
                         markdownText("*Customer Name:*\n$customerName")