Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tu-02-49): search autocomplete #173

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

ki8vi
Copy link
Collaborator

@ki8vi ki8vi commented Aug 29, 2024

PR Title ✨

πŸ“ conforms with the following format:

  • prefix (following the convention: feat, fix, hotfix, chore, refactor, revert, docs, style, test)
  • sprint and issue number (e.g. tu-01-02, where 01 - is the sprint number and 02 - is the issue number)
  • short description

πŸ‘€ Example: feat(tu-01-02): description

PR Description πŸ§™β€β™‚οΈ

  • add filter for autocmplete search, first the search is done by the cities that exists and if it doesn't find it then it looks for fake cities, and to avoid duplication Set is used
  • add notification in case cities are entered that do not exist
  • add active index for switching to first tab after search

Auto-Review πŸ€–

  • The reviewers have been requested πŸ“
    Request Review on PR Open
  • The labels have been added 🎨
    Pull Request Labeler
  • My code doesn't generate any errors or warnings ⚠️
    Code Formatter
  • My code passes all tests πŸ§ͺ
    Test
  • My code builds successfully βš™οΈ
    Netlify Status

Self-Check 🌟

  • I wrote the correct title for the PR πŸ—οΈ
  • I wrote a comprehensive description for the PR πŸ“œ
  • I have performed a self-review of my own code βœ…
  • I have commented my code where needed πŸ“
  • I am happy with my PR and ready to merge ❀️‍πŸ”₯

Copy link

netlify bot commented Aug 29, 2024

βœ… Deploy Preview for mad-wizards-tu-tu ready!

Name Link
πŸ”¨ Latest commit 4c5e45a
πŸ” Latest deploy log https://app.netlify.com/sites/mad-wizards-tu-tu/deploys/66d0bdc3b0a5d100085285b8
😎 Deploy Preview https://deploy-preview-173--mad-wizards-tu-tu.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stardustmeg stardustmeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job ❀️

Copy link
Owner

@Kleostro Kleostro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!❀️‍πŸ”₯

@ki8vi ki8vi merged commit d5ed78e into sprint-2 Aug 29, 2024
8 checks passed
@ki8vi ki8vi deleted the fix/tu-02-49/search-autocomplete branch August 29, 2024 19:54
@stardustmeg
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants