Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tu-02-65): ride confirmation modal #194

Merged
merged 1 commit into from
Sep 5, 2024
Merged

refactor(tu-02-65): ride confirmation modal #194

merged 1 commit into from
Sep 5, 2024

Conversation

stardustmeg
Copy link
Collaborator

@stardustmeg stardustmeg commented Sep 5, 2024 •
edited
Loading

PR Title ✨

📍 conforms with the following format:

  • prefix (following the convention: feat, fix, hotfix, chore, refactor, revert, docs, style, test)
  • sprint and issue number (e.g. tu-01-02, where 01 - is the sprint number and 02 - is the issue number)
  • short description

👀 Example: feat(tu-01-02): description

PR Description 🧙‍♂️

Styles 🎨

  • update delete ride confirmation modal window to be consistent with delete route modal window

Auto-Review 🤖

  • The reviewers have been requested 📝
    Request Review on PR Open
  • The labels have been added 🎨
    Pull Request Labeler
  • My code doesn't generate any errors or warnings ⚠️
    Code Formatter
  • My code passes all tests 🧪
    Test
  • My code builds successfully ⚙️
    Netlify Status

Self-Check 🌟

  • I wrote the correct title for the PR 🗝️
  • I wrote a comprehensive description for the PR 📜
  • I have performed a self-review of my own code ✅
  • I have commented my code where needed 📝
  • I am happy with my PR and ready to merge ❤️‍🔥

ki8vi
ki8vi approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@ki8vi ki8vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🔥

@stardustmeg stardustmeg merged commit a27ec87 into develop Sep 5, 2024
4 checks passed
@stardustmeg stardustmeg deleted the refactor/tu-02-65/ride-modal branch September 5, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katyastan katyastan katyastan approved these changes

@ki8vi ki8vi ki8vi approved these changes

@Kleostro Kleostro Awaiting requested review from Kleostro

Assignees
No one assigned
Labels
refactor 🚧 sprint2 🎫 styles 🪄
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stardustmeg @ki8vi @katyastan