Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(tu-01-36): add ng zorro icons #42

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

stardustmeg
Copy link
Collaborator

@stardustmeg stardustmeg commented Aug 16, 2024

PR Title ✨

πŸ“ conforms with the following format:

  • prefix (following the convention: feat, fix, hotfix, chore, refactor, revert, docs, style, test)
  • sprint and issue number (e.g. tu-01-02, where 01 - is the sprint number and 02 - is the issue number)
  • short description

πŸ‘€ Example: feat(tu-01-02): description

PR Description πŸ§™β€β™‚οΈ

Styles 🎨

  • add ng zorro icons to the project

Provide any other relevant information πŸ¦‰

i.e.
app.config.ts: const icons: IconDefinition[] = [AlertOutline];
header.ts: <span nz-icon nzType="alert" nzTheme="outline"></span>

Auto-Review πŸ€–

  • The reviewers have been requested πŸ“
    Request Review on PR Open
  • The labels have been added 🎨
    Pull Request Labeler
  • My code doesn't generate any errors or warnings ⚠️
    Code Formatter
  • My code passes all tests πŸ§ͺ
    Test
  • My code builds successfully βš™οΈ
    Netlify Status

Self-Check 🌟

  • I wrote the correct title for the PR πŸ—οΈ
  • I wrote a comprehensive description for the PR πŸ“œ
  • I have performed a self-review of my own code βœ…
  • I have commented my code where needed πŸ“
  • I am happy with my PR and ready to merge ❀️‍πŸ”₯

Copy link
Collaborator

@ki8vi ki8vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow icons)

@stardustmeg stardustmeg merged commit 371b81a into sprint-1 Aug 16, 2024
4 checks passed
@stardustmeg stardustmeg deleted the style/tu-01-36/add-ng-zorro-icons branch August 16, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants