Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tu-01-10): station coordinates input #52

Merged
merged 5 commits into from
Aug 17, 2024

Conversation

Kleostro
Copy link
Owner

@Kleostro Kleostro commented Aug 17, 2024

PR Title ✨

πŸ“ conforms with the following format:

  • prefix (following the convention: feat, fix, hotfix, chore, refactor, revert, docs, style, test)
  • sprint and issue number (e.g. tu-01-02, where 01 - is the sprint number and 02 - is the issue number)
  • short description

πŸ‘€ Example: feat(tu-01-02): description

PR Description πŸ§™β€β™‚οΈ

  • implement create station form
  • implement map component

Screenshots/Demo πŸ“Έ

image

Auto-Review πŸ€–

  • The reviewers have been requested πŸ“
    Request Review on PR Open
  • The labels have been added 🎨
    Pull Request Labeler
  • My code doesn't generate any errors or warnings ⚠️
    Code Formatter
  • My code passes all tests πŸ§ͺ
    Test
  • My code builds successfully βš™οΈ
    Netlify Status

Self-Check 🌟

  • I wrote the correct title for the PR πŸ—οΈ
  • I wrote a comprehensive description for the PR πŸ“œ
  • I have performed a self-review of my own code βœ…
  • I have commented my code where needed πŸ“
  • I am happy with my PR and ready to merge ❀️‍πŸ”₯

@Kleostro
Copy link
Owner Author

Copy link
Collaborator

@ki8vi ki8vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great )

Copy link
Collaborator

@stardustmeg stardustmeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! Thanks ❀️‍πŸ”₯
Left a couple of suggestions for you πŸ™ƒ

autocomplete="off"
/>
@if (createStationForm.controls.city; as city) {
<ng-container *ngIf="city.invalid && city.dirty">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we avoid using *ngIf modules? πŸ™ƒ

@@ -0,0 +1,5 @@
<div class="map-wrap">
<div class="map" #map>
<p-skeleton width="100%" height="100%" [hidden]="isMapLoaded()" />
Copy link
Collaborator

@stardustmeg stardustmeg Aug 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of skeleton πŸ‘πŸ»

@Kleostro Kleostro merged commit eb9a35d into sprint-1 Aug 17, 2024
2 checks passed
@Kleostro Kleostro deleted the feat/tu-01-10/station-coordinates-input branch August 17, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tu-01-10] Station coordinates input πŸš‰
3 participants