-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tu-01-10): station coordinates input #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job! Thanks β€οΈβπ₯
Left a couple of suggestions for you π
autocomplete="off" | ||
/> | ||
@if (createStationForm.controls.city; as city) { | ||
<ng-container *ngIf="city.invalid && city.dirty"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we avoid using *ngIf
modules? π
@@ -0,0 +1,5 @@ | |||
<div class="map-wrap"> | |||
<div class="map" #map> | |||
<p-skeleton width="100%" height="100%" [hidden]="isMapLoaded()" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of skeleton ππ»
PR Title β¨
π conforms with the following format:
feat
,fix
,hotfix
,chore
,refactor
,revert
,docs
,style
,test
)tu-01-02
, where01
- is the sprint number and02
- is the issue number)π Example:
feat(tu-01-02): description
PR Description π§ββοΈ
Screenshots/Demo πΈ
Auto-Review π€
Self-Check π