Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tu-01-03): error handling #56

Merged
merged 5 commits into from
Aug 17, 2024
Merged

Conversation

katyastan
Copy link
Collaborator

@katyastan katyastan commented Aug 17, 2024

PR Title ✨

πŸ“ conforms with the following format:

  • prefix (following the convention: feat, fix, hotfix, chore, refactor, revert, docs, style, test)
  • sprint and issue number (e.g. tu-01-02, where 01 - is the sprint number and 02 - is the issue number)
  • short description

πŸ‘€ Example: feat(tu-01-02): description

PR Description πŸ§™β€β™‚οΈ

Add:
The Sign Up page should display appropriate error messages if the password and repeat password fields do not match.
The Sign Up page should display an error message if an account with the provided email already exists.

Acceptance Criteria:
Display "Account with this email already exists" error message when the user tries to sign up with an email that is already registered.
Display "Required" error message under the empty form fields after Register button is clicked first time. Error does not appear until user click button regardless of content.

Add test for register.component.
Add error messages for sign-up API

Auto-Review πŸ€–

  • The reviewers have been requested πŸ“
    Request Review on PR Open
  • The labels have been added 🎨
    Pull Request Labeler
  • My code doesn't generate any errors or warnings ⚠️
    Code Formatter
  • My code passes all tests πŸ§ͺ
    Test
  • My code builds successfully βš™οΈ
    Netlify Status

Self-Check 🌟

  • I wrote the correct title for the PR πŸ—οΈ
  • I wrote a comprehensive description for the PR πŸ“œ
  • I have performed a self-review of my own code βœ…
  • I have commented my code where needed πŸ“
  • I am happy with my PR and ready to merge ❀️‍πŸ”₯

Copy link

netlify bot commented Aug 17, 2024

βœ… Deploy Preview for mad-wizards-tu-tu ready!

Name Link
πŸ”¨ Latest commit 53fc1db
πŸ” Latest deploy log https://app.netlify.com/sites/mad-wizards-tu-tu/deploys/66c115fb9a946800080fe4da
😎 Deploy Preview https://deploy-preview-56--mad-wizards-tu-tu.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@katyastan
Copy link
Collaborator Author

Copy link
Owner

@Kleostro Kleostro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much ❀️‍πŸ”₯
Left a small comment, please have a look at it.

src/app/auth/pages/register/register.component.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@stardustmeg stardustmeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks so much ❀️

Copy link
Owner

@Kleostro Kleostro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❀️‍πŸ”₯

Copy link
Collaborator

@ki8vi ki8vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool )

@katyastan katyastan merged commit 399c295 into sprint-1 Aug 17, 2024
6 checks passed
@katyastan katyastan deleted the feat/tu-01-03/error-handling branch August 17, 2024 21:41
@stardustmeg stardustmeg linked an issue Aug 17, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tu-01-03] Error Handling πŸ”
4 participants