-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tu-01-03): error handling #56
Conversation
β Deploy Preview for mad-wizards-tu-tu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much β€οΈβπ₯
Left a small comment, please have a look at it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks so much β€οΈ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! β€οΈβπ₯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool )
PR Title β¨
π conforms with the following format:
feat
,fix
,hotfix
,chore
,refactor
,revert
,docs
,style
,test
)tu-01-02
, where01
- is the sprint number and02
- is the issue number)π Example:
feat(tu-01-02): description
PR Description π§ββοΈ
Add:
The Sign Up page should display appropriate error messages if the password and repeat password fields do not match.
The Sign Up page should display an error message if an account with the provided email already exists.
Acceptance Criteria:
Display "Account with this email already exists" error message when the user tries to sign up with an email that is already registered.
Display "Required" error message under the empty form fields after Register button is clicked first time. Error does not appear until user click button regardless of content.
Add test for register.component.
Add error messages for sign-up API
Auto-Review π€
Self-Check π