Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Forge formatting check to CI #78

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add Forge formatting check to CI #78

wants to merge 2 commits into from

Conversation

0xAurelius
Copy link
Contributor

Opened from my personal fork, whoops

@0xAurelius 0xAurelius self-assigned this Dec 27, 2024
@0xAurelius
Copy link
Contributor Author

Hmm @psparacino is there a reason we are running the test.yml workflow only on workflow_dispatch (which means we have to manually trigger it?)

Shouldn't we be running the forge build, tests and formatting on every PR?

@vercel Vercel
Copy link

vercel bot commented Dec 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solidity ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 4:08pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psparacino psparacino Awaiting requested review from psparacino

At least 1 approving review is required to merge this pull request.

Assignees

@0xAurelius 0xAurelius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xAurelius