Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#117 labels for nodes implemented #158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oskarjerzyk
Copy link
Contributor

Description

Motivation and Context

Screenshots (if appropriate)

Upgrade notes (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@oskarjerzyk oskarjerzyk changed the title #117 labels for nodes implemented Knotx/knotx-fragments#117 labels for nodes implemented May 20, 2020
@oskarjerzyk oskarjerzyk changed the title Knotx/knotx-fragments#117 labels for nodes implemented #117 labels for nodes implemented May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #158 into master will decrease coverage by 0.00%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #158      +/-   ##
============================================
- Coverage     90.83%   90.82%   -0.01%     
- Complexity     1618     1620       +2     
============================================
  Files           153      153              
  Lines          6776     6780       +4     
  Branches        184      185       +1     
============================================
+ Hits           6155     6158       +3     
  Misses          527      527              
- Partials         94       95       +1     
Impacted Files Coverage Δ Complexity Δ
...agments/task/factory/generic/GraphNodeOptions.java 83.01% <42.85%> (-0.66%) 18.00 <2.00> (+2.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7039d...ae7ac3d. Read the comment docs.

@@ -35,6 +35,7 @@
public class GraphNodeOptions {

private NodeOptions node;
private String label;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this label should be used in GraphNodeExecutionLog. Can you please verify if it is passed correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants