Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Config class, separating its responsibilities into PortalConfig and ConfigLoader #163

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

mosoriob
Copy link
Contributor

The Config class is currently handling multiple responsibilities, including:

  • Managing the portal.properties file data structure
  • Handling permission validation, such as checkDomain, dynamic user configuration setup, and viewerID management.

To improve maintainability and readability, we should separate these responsibilities into separate classes or functions. This will make the code easier to understand and modify in the future.

Proposed Solution

Create two new classes:

  • Config to handle the portal.properties file data structure
  • ConfigLoader to handle permission validation and dynamic configuration

Benefits

  • Improved readability and maintainability of the codebase
  • Clear separation of concerns for better organization
  • Easier testing and debugging of individual components

Copy link
Contributor Author

@mosoriob mosoriob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@mosoriob mosoriob merged commit bcaf8ec into master Jul 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant