Refactor Config class, separating its responsibilities into PortalConfig and ConfigLoader #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Config
class is currently handling multiple responsibilities, including:portal.properties
file data structurecheckDomain
, dynamic user configuration setup, andviewerID
management.To improve maintainability and readability, we should separate these responsibilities into separate classes or functions. This will make the code easier to understand and modify in the future.
Proposed Solution
Create two new classes:
Config
to handle theportal.properties
file data structureConfigLoader
to handle permission validation and dynamic configurationBenefits