add remote manager #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autumn60
reviewed
Jan 25, 2025
Comment on lines
+19
to
+21
| void Drive(const geometry_msgs::Twist& cmd_vel_used); | ||
| void Stop(); | ||
| void Pause(); |
There was a problem hiding this comment.
For consistent naming of functions.
Suggested change
| void Drive(const geometry_msgs::Twist& cmd_vel_used); | |
| void Stop(); | |
| void Pause(); | |
| void drive(const geometry_msgs::Twist& cmd_vel_used); | |
| void stop(); | |
| void pause(); |
Autumn60
reviewed
Jan 25, 2025
| <exec_depend>roscpp</exec_depend> | ||
| <exec_depend>std_msgs</exec_depend> | ||
| <exec_depend>geometry_msgs</exec_depend> | ||
|
|
There was a problem hiding this comment.
Suggested change
| <exec_depend>mqtt_client</exec_depend> | |
Autumn60
reviewed
Jan 25, 2025
Comment on lines
+9
to
+10
| int frequency; | ||
| pn.param<int>("frequency", frequency, 20); |
There was a problem hiding this comment.
ref: https://docs.ros.org/en/diamondback/api/rostime/html/classros_1_1Rate.html
Suggested change
| int frequency; | |
| pn.param<int>("frequency", frequency, 20); | |
| double frequency; | |
| pn.param<double>("frequency", frequency, 20.0); |
Autumn60
reviewed
Jan 25, 2025
| @@ -56,7 +57,15 @@ | |||
| <node pkg="nvt_core" type="launch_delayed.sh" args="5 roslaunch nvt_core perception.launch" name="nvt_perception" output="screen" /> | |||
|
|
|||
| <!-- ======== Planning ======== --> | |||
| <group unless="$(arg remote)"> | |||
| <node pkg="nvt_core" type="launch_delayed.sh" args="5 roslaunch nvt_core planning.launch" name="nvt_planning" output="screen" /> | |||
There was a problem hiding this comment.
Suggested change
| <node pkg="nvt_core" type="launch_delayed.sh" args="5 roslaunch nvt_core planning.launch" name="nvt_planning" output="screen" /> | |
| <node pkg="nvt_core" type="launch_delayed.sh" args="5 roslaunch nvt_core planning.launch" name="nvt_planning" output="screen" /> |
Autumn60
reviewed
Jan 25, 2025
| #define REMOTE_MANAGER_H | ||
|
|
||
| #include <ros/ros.h> | ||
| #include <time.h> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.