Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url encoding #679

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Fix url encoding #679

merged 3 commits into from
Feb 7, 2025

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Feb 6, 2025

Fixes Koenkk/zigbee2mqtt#26210

Note that I ran a reprocess before (#678)

@Koenkk Koenkk requested a review from Nerivec February 6, 2025 20:39
@Koenkk Koenkk added the ignore-ota-workflow Do not run workflow to validate image files in PR label Feb 6, 2025
@Nerivec
Copy link
Collaborator

Nerivec commented Feb 6, 2025

I had removed the add.js encoding logic, for some reason that currently escapes me (haha)...
There aren't that many affected URLs, maybe it would be better to remove non-confirming characters entirely (i.e. rename files/fix indexes) and then add a check for new PRs to prevent introduction of new poorly named files (like alpha-num-dash only)?
I'll see if I can find my notes from back when I created the workflows, for the reason I had removed the encoding. It likely was messing with one of the automations in some way though.

@Koenkk
Copy link
Owner Author

Koenkk commented Feb 7, 2025

I'm not sure, you basically have to disallow any character that has to be URL encoded. This seems like a robust solution.

@Koenkk Koenkk merged commit 50db043 into master Feb 7, 2025
1 check passed
@Koenkk Koenkk deleted the fix/url-escaping branch February 7, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-ota-workflow Do not run workflow to validate image files in PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTA Update fails Gledopto GL-B-007P
2 participants