Save all retrieved cookies and get cookies using javascript #18
Conversation
kheldiente
commented
May 21, 2020
•
kheldiente
commented
- Cache all retrieved cookies.
- Fixes Missing cookie values in iOS 10 or lower #17 where clients using iOS 10 or lower have missing cookie values.
kheldiente
changed the title
kheldiente
force-pushed
the
17-Missing-cookie-values-in-iOS-10-or-lower
branch
from
5addbc6
to
cba1960
Compare
| @@ -33,6 +33,8 @@ open class WKCookieWebView: WKWebView { | |||
| // The closure where cookie information is called at update time | |||
| @objc public var onUpdateCookieStorage: ((WKCookieWebView) -> Void)? | |||
|
|
|||
| @objc public var recordedCookies: [HTTPCookie] = []; | |||
There was a problem hiding this comment.
Variables managed only internally
I think private would be better than public.
| @objc public func deleteRecordedCookie(_ cookie: HTTPCookie) { | ||
| recordedCookies.removeAll(where: { $0.name == cookie.name }) | ||
| } | ||
|
|
There was a problem hiding this comment.
also public -> private and remove @objc
Hi @Kofktu , as per testing on my end, setting cookies to HTTPCookieStorage does not work in iOS 10 or lower. I believe this has something to do with evaluateDocumentCookies(webView: WKWebView) having dummy properties in cookies. Also, this validates the intention for storing it in a dedicated array and enabling clients to browse all cookies retrieved by WKCookieWebView, hence it is public. For deleteRecordedCookie(_ cookie: HTTPCookie), I'll remove that one. Commit for improvement is here. |
