Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Alfajores #1

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Config: Alfajores #1

merged 4 commits into from
Dec 27, 2023

Conversation

fabianschu
Copy link
Contributor

@fabianschu fabianschu commented Dec 19, 2023

Description

Please include a summary of the change and if relevant which issue is fixed. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

Please provide instructions so we can test. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas

dev -> master

  • I have checked that all beta deployments have synced
  • I have checked that the earliest block in the polygon pruned deployment is block, date/time
    • The earliest block is more than 24 hours old
  • I have checked that core metrics are the same in the beta and production deployments

Merges to dev

  • I have checked that the graft base is not a pruned deployment

closes #2

export const DAI_ADDRESS = Address.fromString('0x6B175474E89094C44Da98b954EedeAC495271d0F');
export const USDT_ADDRESS = Address.fromString('0xdAC17F958D2ee523a2206206994597C13D831ec7');
export const cUSD_ADDRESS = Address.fromString('0x4a4AC35B50DAf081C22856ebB26561F3a22598C6');
export const USDC_ADDRESS = Address.fromString('0x4a4AC35B50DAf081C22856ebB26561F3a22598C6');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hacky solution, because the code is expecting a USDC address to be set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're referring to the CUSD address on Celo Alfajores, you entered an incorrect address. This is the actual address, and its original source.
CUSD Address ALFAJORES: 0x874069fa1eb16d44d622f2e0ca25eea172369bc1
https://docs.celo.org/es/token-addresses

@fabianschu fabianschu self-assigned this Dec 20, 2023
@fabianschu
Copy link
Contributor Author

The API for the deployed subgraph can be accessed here: https://api.studio.thegraph.com/query/10166/balancer-rfi/version/latest

Copy link
Member

@Another-DevX Another-DevX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls change the CUSD address to the correct one, as the one you have points to an ERC20 called MyToken.
image

@fabianschu
Copy link
Contributor Author

I deployed this "cUSD" contract to alfajores. It has an unprotected mint function so that we can use it to test stuff.

@fabianschu
Copy link
Contributor Author

Merging this PR despite your request for changes, because using our "own" cUSD contract vs the "official" one is useful for us, because it simplifies testing a lot.

@fabianschu fabianschu merged commit c1d5547 into master Dec 27, 2023
3 checks passed
@fabianschu fabianschu deleted the config/alfajores branch December 27, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add support for alfajores
2 participants