Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report some specific errors in get_yaml #2234

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Report some specific errors in get_yaml #2234

merged 2 commits into from
Sep 23, 2024

Conversation

chazlarson
Copy link
Contributor

Also report the actual error code if it isn't one of those three.

This doesn't actually fix anything related to 2201, but it probably helps with diagnostics

Issues Fixed or Closed

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please delete options that are not relevant.

  • Updated the CHANGELOG with the changes

Also report the actual error code if it isn't one of those three.
@YozoraXCII
Copy link
Contributor

Just to ask - is it worth adding in some more HTTP response message errors?

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status

I appreciate the others may not be as commonly seen and that there is a catchall to just output the response code

@chazlarson
Copy link
Contributor Author

Just to ask - is it worth adding in some more HTTP response message errors?

https://developer.mozilla.org/en-US/docs/Web/HTTP/Status

I appreciate the others may not be as commonly seen and that there is a catchall to just output the response code

I was working from a list and figured specific messages for likely things and the fallback for the stuff that seems like it will never come up.

@meisnate12 meisnate12 merged commit 3d1eb75 into nightly Sep 23, 2024
4 checks passed
@meisnate12 meisnate12 deleted the bug/2201 branch September 23, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants