Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in builder.py #2494

Merged
merged 3 commits into from
Jan 29, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -77,3 +77,5 @@ Fixes an issue where `show_missing` would display missing movies against show li
Fixed an OMDb API issue where API key would intermittently be treated as invalid
Fixed an issue where Kometa would try to upload and cache images larger than Plex allows (10mb is the upper limit)
Fixes an issue where `use_subtitles` would ignore `flag_alignment: left`
Fixed typo `radarr_tag_list` instead of `radarr_taglist` in `builder` module causing `Collection Error: radarr_taglist attribute is blank`
Fixed NoneError when using a blank `radarr_taglist` or `sonarr_taglist`.
6 changes: 3 additions & 3 deletions modules/builder.py
Original file line number Diff line number Diff line change
@@ -59,7 +59,7 @@
item_bool_details = ["item_tmdb_season_titles", "revert_overlay", "item_assets", "item_refresh", "item_analyze"] + item_false_details
item_details = ["non_item_remove_label", "item_label", "item_genre", "item_edition", "item_radarr_tag", "item_sonarr_tag", "item_refresh_delay"] + item_bool_details + list(plex.item_advance_keys.keys())
none_details = ["label.sync", "item_label.sync", "item_genre.sync", "radarr_taglist", "sonarr_taglist", "item_edition"]
none_builders = ["radarr_tag_list", "sonarr_taglist"]
none_builders = ["radarr_taglist", "sonarr_taglist"]
radarr_details = [
"radarr_add_missing", "radarr_add_existing", "radarr_upgrade_existing", "radarr_monitor_existing", "radarr_folder", "radarr_monitor",
"radarr_search", "radarr_availability", "radarr_quality", "radarr_tag", "item_radarr_tag", "radarr_ignore_cache",
@@ -1356,7 +1356,7 @@ def _radarr(self, method_name, method_data):
elif method_name == "radarr_tag":
self.radarr_details["tag"] = util.get_list(method_data, lower=True)
elif method_name == "radarr_taglist":
self.builders.append((method_name, util.get_list(method_data, lower=True)))
self.builders.append((method_name, util.get_list(method_data, lower=True, return_none=False)))
elif method_name == "radarr_all":
self.builders.append((method_name, True))

@@ -1378,7 +1378,7 @@ def _sonarr(self, method_name, method_data):
elif method_name == "sonarr_tag":
self.sonarr_details["tag"] = util.get_list(method_data, lower=True)
elif method_name == "sonarr_taglist":
self.builders.append((method_name, util.get_list(method_data, lower=True)))
self.builders.append((method_name, util.get_list(method_data, lower=True, return_none=False)))
elif method_name == "sonarr_all":
self.builders.append((method_name, True))

4 changes: 2 additions & 2 deletions modules/util.py
Original file line number Diff line number Diff line change
@@ -140,9 +140,9 @@ def add_dict_list(keys, value, dict_map):
else:
dict_map[key] = [int(value)]

def get_list(data, lower=False, upper=False, split=True, int_list=False, trim=True):
def get_list(data, lower=False, upper=False, split=True, int_list=False, trim=True, return_none=True):
if split is True: split = ","
if data is None: return None
if data is None: return None if return_none else []
elif isinstance(data, list): list_data = data
elif isinstance(data, dict): return [data]
elif split is False: list_data = [str(data)]