Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(walletconnect): walletconnect integration #2223
base: dev
Are you sure you want to change the base?
feat(walletconnect): walletconnect integration #2223
Changes from 1 commit
9100780
ca3f558
c3dc6c6
0eea639
588316f
60a2fc5
fd8797c
437767b
6374da3
1c9cfe0
f7987dd
1f2adb2
658357f
98026ac
9dddb91
52a0f72
9f5944c
dff1b42
591fbdb
f6e7864
f535f0b
3eb8969
2d68488
42dd5ba
edcb5a7
e606ca4
d7b5a17
3a85a17
be98c40
6453a33
9f87a9e
6135665
5457d80
9d12079
03d9978
32e46d9
1e352b1
a30511b
341b18e
4c8e299
73d8315
c1accc9
7ab33d5
0bcd41c
b2ec309
2e25bde
328bc76
9b20d7f
ca2e19c
481f1c3
0c00710
e5e2150
8d749de
8b1b6c3
4202950
d440ed9
f3cf28b
e56f8d7
1ab21d7
a498381
c7b41a8
8fc7620
2d52404
4cbd2fa
a57495d
c7e7de6
cc3c568
7683090
5a574a6
81ebee7
46e3802
500cb87
b2dea85
1840ca8
6501134
38dadbe
301a5b0
3cde05b
5eb3e4c
b35bd4a
337154c
b358825
afc4058
18eb62f
9c083ac
7f37fd3
6e57330
e45243b
a8d937e
1569ede
4fc5a43
3792027
0b1da04
f0659a4
187bf5e
2a2f167
cd368bf
0c61287
fe0d096
a0220d7
3468502
c4a07e4
1e78257
a43dc60
eea1532
fb9f8c1
d58b18f
045625b
65c7f90
2326959
42eaa29
4ad423e
e82083a
ad38241
59db165
f5caa19
bb186c2
77d7909
0d3fdfe
35d0fa4
db1e687
11d114d
af91d47
10e9e67
b9075ce
1ff17cd
5e89b9f
1fec24f
bdf9636
31c9594
37a36f7
0351d67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ummm, looks like we skip the first 8bits of the
H520
, thus rendering it essentially anH512
. maybe we could return aPublic = H512
instead ofPublicKey = H520
fromrecover()
.that's just an early suggestion, i will want to check what these trimmed 8bits actually for first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this changed needed ? I think its more appropriate to return Seckp2561 pubkey here
komodo-defi-framework/mm2src/coins/eth/wallet_connect.rs
Lines 211 to 222 in 0d3fdfe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really needed. but I'm trying to understand why we have two different pubkey types and making them into one if possible.
will dig more into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the first octet (byte/8-bits) is a flag to signify that the pubkey is uncompressed (even though one would usually know from the pubkey length, but i guess this is the standard anyways).
0x04
-> uncompressed0x02
-> compressed with even y co-ordinate0x03
-> compressed with odd y co-ordinatehttps://www.rfc-editor.org/rfc/rfc5480#section-2.2
we can leave a little note saying that the first bit is not part of the uncomprssed key but rather just part of the encoding.